-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(packagist): Support for v2
protocol
#20626
feat(packagist): Support for v2
protocol
#20626
Conversation
Blocked by #20595 |
The problem is that I can't test it on the real repository, however you can see the call to |
I had expected that we could remove the hardcoded logic for packagist.org because the new behavior would be to try v2 API first for all registries anyway. Can that be done, or have I misunderstood, or do you prefer to do it gradual? |
Well, I thought about query efficiency, but now I see it's not the case since we cache |
BTW it could also be written so that we "test" v2 first before doing an extra query, so that if there's 10 lookups at once then we don't get 10 failures/unnecessary queries |
I propose more straightforward yet potentially robust solution: always fetch metadata ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
🎉 This PR is included in version 34.154.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: