Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some minor errors #11

Open
ChanceQZ opened this issue Oct 23, 2020 · 0 comments
Open

Some minor errors #11

ChanceQZ opened this issue Oct 23, 2020 · 0 comments

Comments

@ChanceQZ
Copy link

I have installed gsee from pip install gsee. When I used gsee.pv.run_model with example data which I made, I found there are some minor errors in the sourse code:

  1. In 'trigon.py', Line 103, it would be better to delete '.value()' in 'rise_time, set_time = rise_set_times.loc[item.value()]' .
  2. In 'pv.py', you may incorrectly write 'clip(upper=*)' wrong as 'clip_upper'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChanceQZ