Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small TrimUrls bug #60

Closed
vladsadretdinov opened this issue Nov 22, 2017 · 1 comment
Closed

A small TrimUrls bug #60

vladsadretdinov opened this issue Nov 22, 2017 · 1 comment

Comments

@vladsadretdinov
Copy link

vladsadretdinov commented Nov 22, 2017

I add google embed map. Here is his code for example

<iframe src="https://www.google.ru/maps/embed/....."></iframe>

Then if trim_urls filter ON, he replace '/https:/' => '' and in browsers such as Firefox and Opera (in Chrome works fine ) i catch an error

The Google Maps API server rejected your request. Requests to this API must be over SSL. Load the API with "https://" instead of "http://".

To solve the problem, I think you should just avoid replacing URLs in the <iframe> :)

@joaorobertopb
Copy link
Collaborator

Hi @vladSad,
Thanks for the sugestion! But I believe this will not solve the root problem... ( refs #53 )

For now I recommend not register: \RenatoMarinho\LaravelPageSpeed\Middleware\TrimUrls::class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants