Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Type exports correctly #2207

Merged
merged 2 commits into from
May 29, 2024
Merged

fix: Type exports correctly #2207

merged 2 commits into from
May 29, 2024

Conversation

KevinGruber
Copy link
Contributor

As per discussion in: #2206

feat(types): export types
feat(types): add default export

@remy I added two TODO's with questions. Also the TEMP_TEST_TS file is just there for you to easier test it locally, I will remove it before merging.

BR,
Kev

feat(types): add default export
Copy link

netlify bot commented May 28, 2024

Deploy Preview for nodemon ready!

Name Link
🔨 Latest commit d65cc51
🔍 Latest deploy log https://app.netlify.com/sites/nodemon/deploys/6655ccc36164e800078dc5d4
😎 Deploy Preview https://deploy-preview-2207--nodemon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@remy
Copy link
Owner

remy commented May 28, 2024

Looks good to me. If you can remove the tmp file, I'll get it merged it.

chore(types): remove Questions comments
@KevinGruber KevinGruber changed the title Fix Type exports feature/NOTASK Fix Type exports May 28, 2024
@remy
Copy link
Owner

remy commented May 28, 2024

I'll sort out the conventional commitments failure, it's not exactly useful in its error...

@remy remy changed the title feature/NOTASK Fix Type exports fix: Type exports correctly May 29, 2024
@remy remy merged commit 789663c into remy:main May 29, 2024
5 of 7 checks passed
Copy link

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@remy
Copy link
Owner

remy commented May 29, 2024

@KevinGruber thanks again for this - I've merged it as a bug fix rather than feature (which the last introduction of types did). Cheers for flagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants