Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename future flag from fogOfWar to lazyRouteDiscovery #9763

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

brophdawg11
Copy link
Contributor

The "fog of war" phrasing is a nice metaphor for this and works well in blog posts but it's pretty confusing to see as a future flag without the proper context or video game familiarity. We're going to rename the flag for clarity and we'll still use the "fog of war" metaphor in docs and blog posts etc.

Copy link

changeset-bot bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: a47bfe3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Minor
@remix-run/react Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
@remix-run/cloudflare Minor
@remix-run/deno Minor
@remix-run/node Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/serve Minor
create-remix Minor
remix Minor
@remix-run/css-bundle Minor
@remix-run/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +2 to +5
"@remix-run/dev": minor
"@remix-run/react": minor
"@remix-run/server-runtime": minor
"@remix-run/testing": minor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did minor here instead of patch since I'm not considering this a change to a current flag but moreso the deletion of a current flag and the introduction of a new one.

@brophdawg11 brophdawg11 merged commit 629ae99 into dev Jul 18, 2024
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/rename-fog-of-war branch July 18, 2024 12:37
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jul 18, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.11.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Aug 1, 2024

🤖 Hello there,

We just published version 2.11.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant