fix abort behavior for renderToReadableStream #10047
Conversation
🦋 Changeset detectedLatest commit: 4b9036e The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| signal: request.signal, | ||
| // If you wish to abort the rendering process, you can pass a signal here. | ||
| // Please refer to the templates for example son how to configure this. | ||
| // signal: controller.signal, |
There was a problem hiding this comment.
Stop passing the request.signal to fix the issue - but do not add any default timeout behavior to avoid a breaking change
| @@ -9,6 +9,8 @@ import { RemixServer } from "@remix-run/react"; | |||
| import { isbot } from "isbot"; | |||
| import { renderToReadableStream } from "react-dom/server"; | |||
|
|
|||
| const ABORT_DELAY = 5000; | |||
There was a problem hiding this comment.
Templates can have the timeout logic included so that net new apps have it going forward
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
github-actions
bot
removed
the
awaiting release
No description provided.