Assets only imported in resource routes not included in build output

[wKovacs64]

What version of Remix are you using?

1.5.1

Steps to Reproduce

1. Create a resource route
2. Import an asset (e.g., an image)
3. Observe the resulting URL appears correct (includes a hash) 👍
4. Observe the resulting URL 404s as the asset does not make it into the build directory ☹️

Bonus steps:

5. Import the asset into a UI route
6. Observe the asset is now included in the build output

Expected Behavior

I would expect an asset imported (only) in a resource route to be included in the build output.

Actual Behavior

The asset is not included in the build output unless it is also imported in a UI route.

[magnusdr]

I can reproduce this in my project. My current workaround is to put these images in public/ 🤷‍♂️

[wKovacs64]

I can reproduce this in my project. My current workaround is to put these images in public/ 🤷‍♂️

Unfortunately, that approach doesn't benefit from fingerprinting (no hash for cache-busting), if I understand you correctly. My current workaround is to import them (again) in a UI route. 😕

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-916caa6-20220726 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[Xiphe]

Gave v0.0.0-nightly-916caa6-20220726 a shot but the problem seems to persist.

We can work around this by also importing the assets from within our client bundle.

// entry.client.tsx
import { hydrate } from 'react-dom';
import { RemixBrowser } from 'remix';

/* requires are not tree shaken so the imports in that file are considered relevant for the frontend */
require('./routes/my-resouce-route[.]css');

hydrate(<RemixBrowser />, document);

When you have server only code in the resource route you want to be more considerate than this, but you get the idea.

[mcansh]

Gave v0.0.0-nightly-916caa6-20220726 a shot but the problem seems to persist.

yeah, the solution is that of #3841

[Xiphe]

Cool no prob! Thanks for working on this 👍

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-b1b3759-20220928 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[drochag]

Worked like a charm, thank you so much !

[wKovacs64]

Agreed, that seems to have done it. 👍

[machour]

Fixed in 1.7.3 🎉

[manzano78]

@pcattori, FYI this issue reoccurs when we use the unstable vite plugin :) I could reproduce it in one of the latest nightly releases.

[pcattori]

@manzano78 since this issue tracks the bug for the existing compiler, could you open up a separate issue (maybe linking to this one)?

[manzano78]

Sure!