Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected misleading routeParams docs comment. #3810

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Corrected misleading routeParams docs comment. #3810

merged 1 commit into from
Sep 13, 2016

Conversation

thegaryroberts
Copy link
Contributor

The actual type of this.props.params.portfolioId will be a string as opposed to a number.

The actual type of this.props.params.portfolioId will be a string as opposed to a number.
@taion
Copy link
Contributor

taion commented Sep 13, 2016

Thanks.

@taion taion merged commit 4f3ea90 into remix-run:master Sep 13, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants