Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Deprecate routes with nested absolute paths #3246

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Deprecate routes with nested absolute paths #3246

wants to merge 1 commit into from

Conversation

taion
Copy link
Contributor

@taion taion commented Apr 5, 2016

Ref #3172

@taion taion mentioned this pull request Apr 12, 2016
Closed
@mjackson
Copy link
Member

👍 Thanks, @taion.

@mjackson
Copy link
Member

Please don't merge until we know what release this will be a part of.

@taion
Copy link
Contributor Author

taion commented Apr 12, 2016

I'd recommend against merging this for a while, BTW. I had it merged on rrtr for like a few hours, but changed my mind and backed it out: taion/rrtr#11. This doesn't add any direct value to users until a breaking release that actually gets rid of the underlying feature is possible.

@mjackson mjackson mentioned this pull request Apr 13, 2016
Closed
4 tasks
@taion taion changed the title Deprecate routes with nested absolute paths [DO NOT MERGE] Deprecate routes with nested absolute paths Apr 13, 2016
This was referenced Apr 14, 2016
Closed
Merged
@ryanflorence ryanflorence added this to the next-3.0.0 milestone Apr 14, 2016
@ryanflorence
Copy link
Member

ryanflorence commented Apr 14, 2016 •
edited
Loading

Added the 3.0 milestone. We don't want to release this until we have features/improvements that depend on it, otherwise it's just annoying to our users. If we get those going we can move this to an earlier release.

@taion, mind enumerating the feature(s) that depend on this?

@taion
Copy link
Contributor Author

taion commented Apr 14, 2016

I'm sorry, I somehow literally lost the branch or repo or something that I submitted this PR from. I'm going to need to remake it.

@taion taion mentioned this pull request Apr 14, 2016
Closed
@ryanflorence ryanflorence removed this from the next-3.0.0 milestone Apr 14, 2016
@ryanflorence
Copy link
Member

Maybe it's in the rrtr fork? :trollface:

@taion
Copy link
Contributor Author

taion commented Apr 15, 2016

Replaced by #3319.

@taion taion closed this Apr 15, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taion @mjackson @ryanflorence @timdorr