Fix partial hydration bugs when hydrating with errors #12070
Conversation
🦋 Changeset detectedLatest commit: 998558f The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| Object.entries(state.errors) | ||
| .filter(([id]) => !matchesToLoad.some((m) => m.route.id === id)) | ||
| .forEach(([routeId, error]) => { | ||
| errors = Object.assign(errors || {}, { [routeId]: error }); | ||
| }); |
There was a problem hiding this comment.
This didn't work because it would lose errors that had bubbled up - we keep all SSR errors since hydration is not the time to "fix" them, and we let errors thrown from the hydration data load take precedence, but I don't think there will ever be overlap. Merging is required though so if a higher route throws we catch the error at the higher boundary.
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
No description provided.