Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Reorganize defs/params and make them configurable #7

Open
jiping-s opened this issue Jun 4, 2021 · 0 comments
Open

config: Reorganize defs/params and make them configurable #7

jiping-s opened this issue Jun 4, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jiping-s
Copy link
Collaborator

jiping-s commented Jun 4, 2021

Background

defs/params.go contains advanced parameters. Some of the values are shared while others are specific to certain packages or individual modules. Some of them also have dependencies on others and cannot be set to any arbitrary values.

What to do

  • Move parameters to corresponding packages or individual units and add them to configuration
  • For parameters that have inter-dependencies, either calculate the values automatically or check the values when loading config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiping-s