Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel entry - show absolute delta value #3563

Merged
merged 3 commits into from
Jul 15, 2023
Merged

Panel entry - show absolute delta value #3563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1290c7
feat(ui): RunInfo - add support for absolute delta value
vio Jul 15, 2023
a7dd5e9
feat(ui): EntryInfo - display absolute delta value
vio Jul 15, 2023
3f37f34
enhance(ui): EntryInfo - improve styling
vio Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/ui/src/components/entry-info/entry-info.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
/** space for close icon */
padding-right: calc(var(--space-medium) + var(--space-xxxsmall) + var(--space-xsmall));
border-bottom: 1px solid var(--color-outline);
background: var(--color-highlight);
}

.headerClose {
Expand Down Expand Up @@ -67,10 +68,6 @@
font-size: var(--size-small);
}

.runs .runsCell {
padding: var(--space-xxxsmall) var(--space-xxsmall);
}

.runs .runsColJob {
white-space: nowrap;
}
Expand All @@ -88,6 +85,7 @@
}

.metaLabel {
margin-right: .6em;
color: var(--color-text-light);
display: inline-block;
margin-right: var(--space-xxxsmall);
min-width: 5em;
}
27 changes: 13 additions & 14 deletions packages/ui/src/components/entry-info/entry-info.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,29 +71,28 @@ export const EntryInfo = (props: EntryInfoProps & React.ComponentProps<'div'>) =
<Stack space="small">
{tags && <div>{tags}</div>}

<Stack space="xxxsmall">
<h3 className={css.label}>
<FileName as="code" name={itemTitle || item.label} className={css.fileName} />
</h3>
<h3 className={css.label}>
<FileName as="code" name={itemTitle || item.label} className={css.fileName} />
</h3>

<RunInfo
current={metricRunInfo.displayValue}
delta={metricRunInfo.displayDeltaPercentage}
deltaType={metricRunInfo.deltaType}
baseline={baselineRun?.displayValue || '0B'}
size="large"
/>
</Stack>
<RunInfo
current={metricRunInfo.displayValue}
delta={metricRunInfo.displayDeltaPercentage}
deltaPercentage={metricRunInfo.displayDelta}
deltaType={metricRunInfo.deltaType}
baseline={baselineRun?.displayValue || '0B'}
size="large"
/>
</Stack>
<button type="button" onClick={onClose} className={css.headerClose}>
<Icon glyph={Icon.ICONS.CLOSE} />
<Icon glyph={Icon.ICONS.CLOSE} size="large" />
</button>
</Box>
<Box padding="small" as="main" className={css.contentWrapper}>
<Stack space="small" className={css.content}>
{children}

<Table outline className={css.runs}>
<Table outline compact className={css.runs}>
<Table.THead>
<Table.Tr>
<Table.Th className={cx(css.runsCell, css.runsColJob)}>&nbsp;</Table.Th>
Expand Down
7 changes: 7 additions & 0 deletions packages/ui/src/components/run-info/run-info.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ Default.args = {
deltaType: 'HIGH_NEGATIVE',
};

export const DeltaPercentage = Template.bind({});

DeltaPercentage.args = {
...Default.args,
deltaPercentage: '+20KiB',
};

export const SizeLarge = Template.bind({});

SizeLarge.args = {
Expand Down
16 changes: 14 additions & 2 deletions packages/ui/src/components/run-info/run-info.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export interface RunInfoProps {
current?: React.ReactNode;
baseline?: string;
delta?: string;
deltaPercentage?: string;
deltaType?: string;

as?: React.ElementType;
Expand All @@ -49,6 +50,7 @@ export const RunInfo = ({
current = '',
baseline = '',
delta = '',
deltaPercentage = '',
deltaType = '',
as: Component = 'div',
size = 'medium',
Expand All @@ -57,7 +59,7 @@ export const RunInfo = ({
enhance = false,
...restProps
}: RunInfoProps & React.ComponentProps<'div'>) => {
const rootClassName = cx(css.root, className, css[size], delta && css.showDelta);
const rootClassName = cx(css.root, className, css[size], (delta || deltaPercentage) && css.showDelta);

const currentValueParams: [React.ReactNode, string?] = useMemo(() => {
if (!enhance || typeof current !== 'string') {
Expand Down Expand Up @@ -96,7 +98,17 @@ export const RunInfo = ({
unit={currentValueParams[1]}
inline
>
{delta && <Delta className={css.delta} displayValue={delta} deltaType={deltaType} />}
{(delta || deltaPercentage) && (
<FlexStack space="xxxsmall" alignItems="center">
{deltaPercentage && (
<FlexStack space="xxxsmall" alignItems="center">
<Delta className={css.delta} displayValue={deltaPercentage} deltaType={deltaType} />
{' / '}
</FlexStack>
)}
{delta && <Delta className={css.delta} displayValue={delta} deltaType={deltaType} />}
</FlexStack>
)}
</Metric>
{showBaseline && <Metric className={css.baselineMetric} value={baseline} />}
</Stack>
Expand Down
Loading