Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16.9: componentWillReceiveProps has been renamed, and is not recommended for use. #480

Closed
bluepeter opened this issue Aug 14, 2019 · 10 comments · Fixed by #483
Closed

Comments

@bluepeter
Copy link

bluepeter commented Aug 14, 2019

See https://fb.me/react-async-component-lifecycle-hooks and https://reactjs.org/blog/2019/08/08/react-v16.9.0.html for details. At minimum, this needs the prefix UNSAFE_ adding to these calls.

json

@Type1J
Copy link

Type1J commented Jan 23, 2020

This issue affects a good number of our projects. As the error says, it's for the upcoming async rendering.

I'm not sure if this use will cause any issues with async rendering, and we should at least try UNSAFE_ once React 17 is released, which would require no further modification.

If it does cause issues in React 17, then we'll cross that bridge when we come to it.

Here's the output of grep -r componentWillReceiveProps * in this project (with no node_modules!).

packages/devui/src/ContextMenu/ContextMenu.js:  componentWillReceiveProps(nextProps) {
packages/devui/src/Editor/Editor.js:  componentWillReceiveProps(nextProps) {
packages/devui/src/Tabs/Tabs.js:  componentWillReceiveProps(nextProps) {
packages/devui/src/Tabs/TabsHeader.js:  componentWillReceiveProps(nextProps) {
packages/react-json-tree/src/index.js:  componentWillReceiveProps(nextProps) {
packages/react-json-tree/src/JSONNestedNode.js:  componentWillReceiveProps(nextProps) {
packages/redux-devtools-core/src/app/components/Settings/Connection.js:  componentWillReceiveProps(nextProps) {
packages/redux-devtools-core/src/app/containers/monitors/Dispatcher.js:  componentWillReceiveProps(nextProps) {
packages/redux-devtools-core/src/app/containers/monitors/InspectorWrapper/ChartTab.js:  componentWillReceiveProps(nextProps) {
packages/redux-devtools-core/src/app/containers/monitors/InspectorWrapper/SubTabs.js:  componentWillReceiveProps(nextProps) {
packages/redux-devtools-inspector/src/ActionList.jsx:  componentWillReceiveProps(nextProps) {
packages/redux-devtools-inspector/src/DevtoolsInspector.js:  componentWillReceiveProps(nextProps) {
packages/redux-devtools-log-monitor/src/LogMonitor.js:  componentWillReceiveProps(nextProps) {

Is there anyone around to make these changes?

If we made a PR, would it be reviewed?

@bluepeter
Copy link
Author

@Type1J it doesn't look as though this repo is maintained, so I'd reco forking and fixing there... and pointing the rest of us to your fork :)

@Type1J
Copy link

Type1J commented Jan 23, 2020

I'd hope that there would be at least 1 maintainer (someone that can merge PRs) to respond. I'll give it a few days.

@neolefty
Copy link

Any responses? I'd like to get a version of the JSON tree viewer at least that only uses the current React API. Maybe it's time to add a new maintainer or fork after all ...

@bluepeter
Copy link
Author

Looks like we are going to have to fork.

This is a recurrent problem w/ open source. I don't get why maintainers can't even respond or delegate the repo to someone else?!

@bluepeter
Copy link
Author

@timdorr can you help please??

@timdorr
Copy link
Member

timdorr commented Mar 10, 2020

See #502. I've just gotten the keys to the castle, so it will take me a bit to get a handle on things and help out here.

@bluepeter
Copy link
Author

Super! Glad to have your steady hands @timdorr at the tiller!

@Type1J
Copy link

Type1J commented Mar 11, 2020

@timdorr Personally, I'm just glad that somebody is able to help out! Your work and time are appreciated.

@bluepeter
Copy link
Author

@timdorr this seems to still be an issue... is there a new version that's coming hopefully?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants