Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get it to work at 120 fps or 240 fps #1

Open
Splat-Tom opened this issue May 23, 2024 · 4 comments
Open

Can't get it to work at 120 fps or 240 fps #1

Splat-Tom opened this issue May 23, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Splat-Tom
Copy link

Hello,

My monitors run at 240 fps, normally when I set the frame rate limiter to 60 fps (1/4) in the game it runs at around 80 because the ingame fps limiter can't math. At this framerate, the plugin seems to work mostly, though the physics seem a bit choppy.
When putting the limiter at 120 or 240 fps however, the physics behave as if a strong wind is blowing whenever I'm running (too much).

at 240 fps without the plugin:
Stiff as a board
image

at 240 with the plugin:
Very wimdy
image

So far the only way I can get the physics to work correctly is to cap my entire monitor's fps to 60 at run it 1/1, but that doesn't involve using the mod.

Is there something I might be forgetting in trying to get this to work at higher fps?

Thank you in advance

@redstrate redstrate self-assigned this May 23, 2024
@redstrate
Copy link
Owner

No it should be working even at 120 FPS (my monitor is 144hz), so either a game update or I broke something. I'll check this out later today

@redstrate
Copy link
Owner

redstrate commented May 24, 2024

Hmm this is odd, I can't reproduce here even when trying at ~200 FPS. I have a debug build available here which may shed like on this issue:

Rebound.zip

(You need to place this in a new folder somewhere, and then add that under the dev plugin path under Dalamud Settings > Experimental. Dalamud will clearly mark which one is the devPlugin one too. I committed the debug window so you can compile it yourself if you don't trust some random plugin zip 😆 )

This build adds a debug window explaining how many times the physics is ran in one second, which should be ~60 (give or take estimation and other errors):

image

If it still counts 60, then maybe it's something else that's wrong but I'm not sure what yet.

Edit: I should also note that in your non-frame limited scenario, you noted the physics are choppy. Unfortunately that's the trade-off with this solution, along with any possible clipping because the character animates quicker than the physics can keep up.

@redstrate redstrate added the bug Something isn't working label May 24, 2024
@Splat-Tom
Copy link
Author

Thanks for the quick response! I'll have a look after work and let you know how it goes.

@Splat-Tom
Copy link
Author

Splat-Tom commented May 27, 2024

Sorry, took a bit longer than I had hoped.

It looks like this for me, when the physics are too 'windy'

image

As for the choppy frames, that might have been an issue on my side because it's far less noticeable right now.

My main issue here is how the physics interact with the hair. It seems to work well for Viera ears, but mainly the hair and the clothes seem weightless and move to their maximum bent angle pretty quickly when just running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants