XTrimArgs Should Allow Limit = 0

[Leoncanva]

Bug Report

Current Behavior

XTrimArgs asserts the maximum numbers of entries to trim is > 0. Calling limit(0) results in exception thrown "Limit must be greater 0"

Stack trace

Limit must be greater 0
java.lang.IllegalArgumentException: 
	at io.lettuce.core.internal.LettuceAssert.isTrue(LettuceAssert.java:208)
	at io.lettuce.core.XTrimArgs.limit(XTrimArgs.java:114)

Input Code

Input Java Code

    var args = XTrimArgs.Builder.minId(minId).approximateTrimming().limit(0l);
    return commands.xtrim(streamKey, args);

Expected behavior/code

Specifying the value 0 as count disables the limiting mechanism entirely.

redis.io/commands/xtrim/

An explicit limit of 0 means unlimited (but note that it's not the default).

redis/redis#8169

Environment

• Lettuce version(s): 6.1.8.RELEASE
• Redis version: >6.2.0

Possible Solution

        LettuceAssert.isTrue(limit >= 0, "Limit must be greater or equal to 0");

[mp911de]

That's fixed now.