Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid buffer copies in RedisStateMachine #2173

Closed
jeffreye opened this issue Aug 1, 2022 · 1 comment
Closed

Avoid buffer copies in RedisStateMachine #2173

jeffreye opened this issue Aug 1, 2022 · 1 comment
Labels
type: feature A new feature
Milestone

Comments

@jeffreye
Copy link

jeffreye commented Aug 1, 2022

Feature Request

Is your feature request related to a problem? Please describe

This will be a performance improvement for all operations

Describe the solution you'd like

Less buffer, less copy. We can reuse the same buffer from Netty by slicing buffer.

Describe alternatives you've considered

NA

Teachability, Documentation, Adoption, Migration Strategy

If you can, explain how users will be able to use this and possibly write out a version the docs.
Maybe a screenshot or design?

@mp911de mp911de linked a pull request Oct 7, 2022 that will close this issue
4 tasks
@mp911de mp911de added the type: feature A new feature label Oct 7, 2022
@mp911de
Copy link
Collaborator

mp911de commented Nov 23, 2022

Looking at the approach, it isn't exactly zero-copy, it's less copy as UnpooledDirectByteBuf holds a buffer and a tmpNioBuf. In any case, it's an improvement.

@mp911de mp911de changed the title zero-copy buffer reader Avoid buffer copies in RedisStateMachine Nov 23, 2022
@mp911de mp911de modified the milestones: 7.x, 6.3 Nov 23, 2022
mp911de pushed a commit that referenced this issue Nov 23, 2022
mp911de added a commit that referenced this issue Nov 23, 2022
Reintroduce deprecated constructor.

Original pull request: #2174
@mp911de mp911de closed this as completed Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants