feat(cluster): support binary keys

Close #637
redis · Jul 19, 2019 · b414ed9 · b414ed9
1 parent 9a113ca
commit b414ed9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -30,7 +30,7 @@
   "author": "luin <i@zihua.li> (http://zihua.li)",
   "license": "MIT",
   "dependencies": {
-    "cluster-key-slot": "^1.0.6",
+    "cluster-key-slot": "^1.1.0",
     "debug": "^4.1.1",
     "denque": "^1.1.0",
     "lodash.defaults": "^4.2.0",

diff --git a/test/unit/command.ts b/test/unit/command.ts
@@ -130,6 +130,10 @@ describe("Command", function() {
   });
 
   describe("#getSlot()", function() {
+    function expectSlot(key: any, slot: number) {
+      expect(new Command("get", [key]).getSlot()).to.eql(slot);
+    }
+
     it("should return correctly", function() {
       expectSlot("123", 5970);
       expectSlot(123, 5970);
@@ -144,10 +148,10 @@ describe("Command", function() {
       expectSlot("", 0);
       expectSlot(null, 0);
       expectSlot(undefined, 0);
+    });
 
-      function expectSlot(key, slot) {
-        expect(new Command("get", [key]).getSlot()).to.eql(slot);
-      }
+    it("supports buffers", () => {
+      expectSlot(Buffer.from("encoding"), 3060);
     });
   });