fix: resolve warning for Buffer() in Node.js 10

redis · Jul 22, 2018 · 6144c56 · 6144c56
1 parent a28983d
commit 6144c56
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/redis.js b/lib/redis.js
@@ -597,7 +597,7 @@ Redis.prototype.sendCommand = function (command, stream) {
 
   if (!writable && command.name === 'quit' && this.offlineQueue.length === 0) {
     this.disconnect();
-    command.resolve(new Buffer('OK'));
+    command.resolve(Buffer.from('OK'));
     return command.promise;
   }
 

diff --git a/lib/redis/parser.js b/lib/redis/parser.js
@@ -71,7 +71,7 @@ exports.returnError = function (err) {
 
 var sharedBuffers = {};
 _.forEach(['message', 'pmessage', 'subscribe', 'psubscribe', 'unsubscribe', 'punsubscribe'], function (str) {
-  sharedBuffers[str] = new Buffer(str);
+  sharedBuffers[str] = Buffer.from(str);
 });
 exports.returnReply = function (reply) {
   if (this.status === 'monitoring') {

diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -35,7 +35,7 @@ exports.bufferEqual = function (a, b) {
  * @return {*} The result
  * @example
  * ```js
- * var input = [new Buffer('foo'), [new Buffer('bar')]];
+ * var input = [Buffer.from('foo'), [Buffer.from('bar')]];
  * var res = convertBufferToString(input, 'utf8');
  * expect(res).to.eql(['foo', ['bar']]);
  * ```