-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the budget extension ability #649
Added the budget extension ability #649
Conversation
athiruma
commented
Jul 27, 2023
- Added the budget extension ability.
- Created the AbstarctMonitorTIckets Interface, so that we can reuse it.
- This will cause the shifting of monitor_in_progress_tickets code from aws/monitor_tickets to AbstractMonitorTickets. So this file looks more.
- Make use of resourcegroupstaggingapi of to tag all resources having the tag TicketId.
- Created the AbstarctMonitorTIckets Interface, so that we can reuse it.
- Added the example mongo_db schema to the data. So we can do sufficient changes in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to avoid large PR, next time split it to small according to subjects
cloud_governance/cloud_resource_orchestration/common/abstract_monitor_tickets.py
Outdated
Show resolved
Hide resolved
cloud_governance/cloud_resource_orchestration/common/abstract_monitor_tickets.py
Outdated
Show resolved
Hide resolved
cloud_governance/cloud_resource_orchestration/common/abstract_monitor_tickets.py
Outdated
Show resolved
Hide resolved
cloud_governance/cloud_resource_orchestration/utils/elastic_search_queries.py
Show resolved
Hide resolved
@@ -0,0 +1,34 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need the es schema ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will help us to identity, which data is currently storing in the Elastic Server
cloud_governance/common/clouds/aws/resource_tagging_api/resource_tag_api_operations.py
Show resolved
Hide resolved
|
||
def cro_monitor_budget_remain_alert(self, ticket_id: str, budget: int, user: str, used_budget: int, remain_budget: int): | ||
""" | ||
This method return subject, body for the budget remain alert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method returns
d56927b
to
249bb11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM