Added the budget extension ability #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
athiruma
commented
Jul 27, 2023
athiruma
commented
- Added the budget extension ability.
- Created the AbstarctMonitorTIckets Interface, so that we can reuse it.
- This will cause the shifting of monitor_in_progress_tickets code from aws/monitor_tickets to AbstractMonitorTickets. So this file looks more.
- Make use of resourcegroupstaggingapi of to tag all resources having the tag TicketId.
- Created the AbstarctMonitorTIckets Interface, so that we can reuse it.
- Added the example mongo_db schema to the data. So we can do sufficient changes in the future.
athiruma
added
documentation
ebattat
reviewed
Jul 28, 2023
cloud_governance/cloud_resource_orchestration/common/abstract_monitor_tickets.py
Outdated
Show resolved
Hide resolved
cloud_governance/cloud_resource_orchestration/common/abstract_monitor_tickets.py
Outdated
Show resolved
Hide resolved
cloud_governance/cloud_resource_orchestration/common/abstract_monitor_tickets.py
Outdated
Show resolved
Hide resolved
cloud_governance/cloud_resource_orchestration/utils/elastic_search_queries.py
Show resolved
Hide resolved
| @@ -0,0 +1,34 @@ | |||
| { | |||
There was a problem hiding this comment.
Why we need the es schema ?
There was a problem hiding this comment.
It will help us to identity, which data is currently storing in the Elastic Server
cloud_governance/common/clouds/aws/resource_tagging_api/resource_tag_api_operations.py
Show resolved
Hide resolved
|
|
||
| def cro_monitor_budget_remain_alert(self, ticket_id: str, budget: int, user: str, used_budget: int, remain_budget: int): | ||
| """ | ||
| This method return subject, body for the budget remain alert |
athiruma
force-pushed
the
alert_ticket_overusage
branch
from
d56927b
to
249bb11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.