Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the elasticsearch operations error #645

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Fixed the elasticsearch operations error #645

merged 1 commit into from
Jul 24, 2023

Conversation

athiruma
Copy link
Collaborator

If err raise in creating the object of elastic search, we make the object equal to None.
Added ping method to elastic search operations. This will help to test the successful connection of ElasticSearch.

@athiruma athiruma added the bug Something isn't working label Jul 24, 2023
@athiruma athiruma requested a review from ebattat July 24, 2023 12:48
@athiruma athiruma self-assigned this Jul 24, 2023
ebattat
ebattat reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athiruma are you sure this is the issue ?

@athiruma
Copy link
Collaborator Author

@athiruma are you sure this is the issue ?

yes,
return self.__es.ping()
59
AttributeError: 'ElasticSearchOperations' object has no attribute '_ElasticSearchOperations__es'. Did you mean: '_ElasticSearchOperations__es_host'?

@athiruma athiruma added the ok-to-test PR ok to test label Jul 24, 2023
ebattat
ebattat approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ebattat ebattat merged commit c392101 into redhat-performance:main Jul 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebattat ebattat ebattat approved these changes

Assignees

@athiruma athiruma

Labels
bug Something isn't working ok-to-test PR ok to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athiruma @ebattat