Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the tagging issue of NA #587

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fixed the tagging issue of NA #587

merged 1 commit into from
Apr 18, 2023

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Apr 18, 2023 •
edited
Loading

  1. Forgot to return the iam_user name after checking in Name tag
  2. Validation of any NA tag present in the tags

@athiruma athiruma added the bug Something isn't working label Apr 18, 2023
@athiruma athiruma requested a review from ebattat April 18, 2023 11:12
@athiruma athiruma self-assigned this Apr 18, 2023
ebattat
ebattat approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit 7d73c76 into redhat-performance:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebattat ebattat ebattat approved these changes

Assignees

@athiruma athiruma

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athiruma @ebattat