Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'dockerfiles' vs 'containerfiles' #57

Closed
tetchel opened this issue May 12, 2021 · 3 comments · Fixed by #69
Closed

'dockerfiles' vs 'containerfiles' #57

tetchel opened this issue May 12, 2021 · 3 comments · Fixed by #69
Assignees
@divyansh42
Labels
enhancement New feature or request

Comments

@tetchel
Copy link
Contributor

tetchel commented May 12, 2021

OCI projects prefer the generic term 'containerfile' over 'dockerfile'.

We should, where we can, replace 'dockerfile' with the generic variant.

currently we have an input called 'dockerfiles'. We don't want to rename that since it would break workflows - but we can add a containerfiles input which is an alias to dockerfiles. Then we can use containerfiles in workflows, if preferred.
@tetchel tetchel added the enhancement New feature or request label May 12, 2021
@tetchel
Copy link
Contributor Author

tetchel commented May 12, 2021

basically, because this looks silly:
image

@tetchel
Copy link
Contributor Author

tetchel commented May 12, 2021

ie redhat-actions/openshift-actions-runners#8

@tetchel
Copy link
Contributor Author

tetchel commented Jul 9, 2021

also update this repo's workflows to use containerfiles instead of dockerfiles

@divyansh42 divyansh42 self-assigned this Sep 1, 2021
@divyansh42 divyansh42 mentioned this issue Sep 1, 2021
Merged
7 tasks
@jpopelka jpopelka mentioned this issue Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@divyansh42 divyansh42

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace dockerfiles with containerfiles divyansh42/buildah-build
2 participants
@tetchel @divyansh42