Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dciborow/cicd #998

Merged
merged 4 commits into from
Dec 5, 2019
Merged

Dciborow/cicd #998

merged 4 commits into from
Dec 5, 2019

Conversation

dciborow
Copy link
Contributor

@dciborow dciborow commented Dec 4, 2019 •
edited
Loading

Description

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@dciborow dciborow changed the base branch from master to staging December 4, 2019 15:11
miguelgfierro
miguelgfierro approved these changes Dec 5, 2019
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really good

@miguelgfierro miguelgfierro merged commit 51ca416 into staging Dec 5, 2019
@miguelgfierro miguelgfierro deleted the dciborow/cicd branch December 5, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dciborow @miguelgfierro