Papermill scalffold example #681

jingyanwangms · 2019-03-26T07:56:32Z

Description

This noteboook provides a scaffold to directly submit an existing notebook to AzureML compute targets. Now a user doesn't have to rewrite the training script, instead, just by replacing file name, now user can submit notebook directly.

Notes:

I added line run_config_aml.environment.python.conda_dependencies.remove_conda_package("pip>=19.0.3") as workaround for what I think is a bug in azureml.core
All AzureML notebook cannot be smoke tested yet. Will track aml test infrastructure separately, see Issue 547

Related Issues

Issue 695 [BUG] Remove contrib from azureml

Checklist:

My code follows the code style of this project, as detailed in our contribution guidelines.
I have added tests.
I have updated the documentation accordingly.

review-notebook-app · 2019-03-26T07:56:33Z

Check out this pull request on ReviewNB: https://app.reviewnb.com/Microsoft/Recommenders/pull/681

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

miguelgfierro

This looks really good @jingyanwangms. I have some questions and suggestions

myenv2.yaml

notebooks/00_quick_start/run_notebook_on_aml.ipynb

miguelgfierro · 2019-03-26T10:20:36Z

hey @jingyanwangms, this is really good, it is in fact one of the works that we need the most.

Question, what is the relation of this PR with this other one #575?

notebooks/00_quick_start/run_notebook_on_aml.ipynb

yueguoguo

@jingyanwangms just my two cents, it would be good to have some information in the notebook put at a place where all information about setting up Azure, benefits of Azure, etc. is found. I personally think the expectation of this notebook is about how to run a recommender quickstart/deepdive/hyper-tuning notebook on AzureML Service.

What do you think?

notebooks/00_quick_start/run_notebook_on_aml.ipynb

notebooks/00_quick_start/run_notebook_on_azureml.ipynb

gramhagen · 2019-04-10T12:52:44Z

notebooks/00_quick_start/run_notebook_on_azureml.ipynb

@@ -0,0 +1,290 @@
+{


i think we should merge #728 first and then use the get_or_create_workspace function there to minimize use of scripts post-setup

Reply via ReviewNB

I'm hoping this PR can make it into master with #720 . If #728 can get in with, then I will rebase to use get_or_create_workspace

#728 is merged to staging

rebased to latest staging

notebooks/00_quick_start/run_notebook_on_azureml.ipynb

gramhagen · 2019-04-10T12:57:19Z

How are we differentiating this and the run_sar_on_aml notebook? there's some repetition between those two, so it's a little confusing if they are basically the same, or if one way is better than another? Personally I like having a separate notebook that will just execute the notebook as is, instead of having to integrate azureml into the notebook, but clarifying the two approaches (pros/cons) might help.

heatherbshapiro · 2019-04-10T19:02:49Z

@gramhagen the benefit of this notebook is to show that you can submit any notebook as is to azureML without changing any code. the other notebook is an example of how you COULD change the code to be able to utilize items like data store, estimators, etc that are found in AzureML. I think this would be better suited in the notebooks folder rather than quickstart

notebooks/00_quick_start/run_notebook_on_azureml.ipynb

miguelgfierro · 2019-04-11T10:32:24Z

awesome work @jingyanwangms!!!

miguelgfierro · 2019-04-11T15:39:18Z

mmm @gramhagen it looks there is a conflict between the changes you made notebooks/00_quick_start/sar_movielens_with_azureml.ipynb and this PR

heatherbshapiro

I still think that run based creation for the compute will take too long. If a user is submitting multiple notebooks to test out, it will take them over 10 minutes every time to create, prepare, and then finally train. I think we should either show both ways to do it, or only show the persistent compute so that if a user does it once, they can easily switch to a new notebook and it should be much faster.

gramhagen · 2019-04-11T20:32:53Z

yeah, one of us will need to go through and resolve those changes. I can take a stab at it tomorrow unless you'd rather do it @jingyanwangms ?

heatherbshapiro · 2019-04-11T21:36:25Z

notebooks/00_quick_start/run_notebook_on_azureml.ipynb

+    "![Experiment submit output](https://recodatasets.blob.core.windows.net/images/aml_papermill_cell_output.jpg)\n",
+    "After clicking \"Link to Azure Portal\", experiment run details tab looks like this\n",
+    "![Azure Portal Experiment](https://recodatasets.blob.core.windows.net/images/aml_papermill_portal.jpg)\n",
+    "Experiment output is out.ipynb. You can download and view this file locally.\n",


This is not the experiment output. The metrics are logged to the run, and the out.ipynb is the notebook that was initially submitted. I don't think we need the image

I just tried submitting a notebook without output and out.ipynb comes with output. I think out.ipynb is the notebook after the run

I just meant that the text is incorrect. It is not output from the experiment. They can see the notebook that was submitted to the experiment logged as out.ipynb

jingyanwangms · 2019-04-12T08:32:17Z

@heatherbshapiro I changed the notebook to use persistent compute

jingyanwangms · 2019-04-12T08:32:53Z

@gramhagen Rebased this pr to latest staging

heatherbshapiro · 2019-04-12T13:50:40Z

Can we please move to the notebook folder rather than the quickstart?

jingyanwangms · 2019-04-12T17:23:51Z

@heatherbshapiro moved to notebooks/ and changed text as You can find the executed notebook out.ipynb under outputs tab.

Papermill scalffold example

jingyanwangms added the azureml label Mar 26, 2019

jingyanwangms requested review from miguelgfierro and yueguoguo as code owners March 26, 2019 07:56

miguelgfierro requested changes Mar 26, 2019

View reviewed changes

myenv2.yaml Outdated Show resolved Hide resolved

miguelgfierro reviewed Mar 26, 2019

View reviewed changes

heatherbshapiro reviewed Mar 27, 2019

View reviewed changes

heatherbshapiro suggested changes Apr 3, 2019

View reviewed changes

heatherbshapiro reviewed Apr 3, 2019

View reviewed changes

notebooks/00_quick_start/run_notebook_on_aml.ipynb Outdated Show resolved Hide resolved

heatherbshapiro reviewed Apr 3, 2019

View reviewed changes

notebooks/00_quick_start/run_notebook_on_aml.ipynb Outdated Show resolved Hide resolved

yueguoguo reviewed Apr 7, 2019

View reviewed changes

notebooks/00_quick_start/run_notebook_on_aml.ipynb Outdated Show resolved Hide resolved

notebooks/00_quick_start/run_notebook_on_aml.ipynb Outdated Show resolved Hide resolved

jingyanwangms force-pushed the jingywa/papermill2 branch from bbdd4e8 to bab35af Compare April 9, 2019 04:36

jingyanwangms requested review from heatherbshapiro and miguelgfierro April 9, 2019 05:46

miguelgfierro reviewed Apr 9, 2019

View reviewed changes

notebooks/00_quick_start/run_notebook_on_azureml.ipynb Outdated Show resolved Hide resolved

notebooks/00_quick_start/run_notebook_on_azureml.ipynb Outdated Show resolved Hide resolved

gramhagen reviewed Apr 10, 2019

View reviewed changes

heatherbshapiro reviewed Apr 10, 2019

View reviewed changes

notebooks/00_quick_start/run_notebook_on_azureml.ipynb Outdated Show resolved Hide resolved

heatherbshapiro reviewed Apr 10, 2019

View reviewed changes

notebooks/00_quick_start/run_notebook_on_azureml.ipynb Outdated Show resolved Hide resolved

miguelgfierro approved these changes Apr 11, 2019

View reviewed changes

heatherbshapiro reviewed Apr 11, 2019

View reviewed changes

jingyanwangms and others added 3 commits April 11, 2019 22:00

remove azureml-contrib

0243375

Prototype of running a notebook on azureml

426e84a

papermill scalffold

4ee26a9

jingyanwangms added 15 commits April 11, 2019 22:00

remove subscription

d84b67f

edit text

c36474f

update version and variable names

ba6130c

PR comments

ad06e80

add widgets

af408b9

rename

1e07458

fix azureml.core bug

20e1dfe

PR comments

e705fba

remove error output

23fb6e8

add back tensorboards

1615fe7

use CondaDependencies.create()

2f27ae2

remove generate_conda_script

5bb3486

PR comments

71bab73

PR comments and rebased

1711521

rebase

a55d040

jingyanwangms requested a review from heatherbshapiro April 12, 2019 08:32

jingyanwangms force-pushed the jingywa/papermill2 branch from 2599165 to a55d040 Compare April 12, 2019 08:34

move notebook and fix wording

7529e59

miguelgfierro merged commit 427fefd into recommenders-team:staging Apr 15, 2019

miguelgfierro added this to the Papermill in AzureML milestone Apr 25, 2019

yueguoguo pushed a commit that referenced this pull request Sep 9, 2019

Merge pull request #681 from jingyanwangms/jingywa/papermill2

7d1ab59

Papermill scalffold example

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Papermill scalffold example #681

Papermill scalffold example #681

jingyanwangms commented Mar 26, 2019 •

edited

Loading

review-notebook-app bot commented Mar 26, 2019

miguelgfierro left a comment

miguelgfierro commented Mar 26, 2019

yueguoguo left a comment

gramhagen Apr 10, 2019

jingyanwangms Apr 11, 2019

gramhagen Apr 11, 2019

jingyanwangms Apr 12, 2019

gramhagen commented Apr 10, 2019

heatherbshapiro commented Apr 10, 2019

miguelgfierro commented Apr 11, 2019

miguelgfierro commented Apr 11, 2019

heatherbshapiro left a comment

gramhagen commented Apr 11, 2019

heatherbshapiro Apr 11, 2019

jingyanwangms Apr 12, 2019

heatherbshapiro Apr 12, 2019

jingyanwangms commented Apr 12, 2019

jingyanwangms commented Apr 12, 2019

heatherbshapiro commented Apr 12, 2019

jingyanwangms commented Apr 12, 2019

Papermill scalffold example #681

Papermill scalffold example #681

Conversation

jingyanwangms commented Mar 26, 2019 • edited Loading

Description

Related Issues

Checklist:

review-notebook-app bot commented Mar 26, 2019

miguelgfierro left a comment

Choose a reason for hiding this comment

miguelgfierro commented Mar 26, 2019

yueguoguo left a comment

Choose a reason for hiding this comment

gramhagen Apr 10, 2019

Choose a reason for hiding this comment

jingyanwangms Apr 11, 2019

Choose a reason for hiding this comment

gramhagen Apr 11, 2019

Choose a reason for hiding this comment

jingyanwangms Apr 12, 2019

Choose a reason for hiding this comment

gramhagen commented Apr 10, 2019

heatherbshapiro commented Apr 10, 2019

miguelgfierro commented Apr 11, 2019

miguelgfierro commented Apr 11, 2019

heatherbshapiro left a comment

Choose a reason for hiding this comment

gramhagen commented Apr 11, 2019

heatherbshapiro Apr 11, 2019

Choose a reason for hiding this comment

jingyanwangms Apr 12, 2019

Choose a reason for hiding this comment

heatherbshapiro Apr 12, 2019

Choose a reason for hiding this comment

jingyanwangms commented Apr 12, 2019

jingyanwangms commented Apr 12, 2019

heatherbshapiro commented Apr 12, 2019

jingyanwangms commented Apr 12, 2019

jingyanwangms commented Mar 26, 2019 •

edited

Loading