Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding vowpal wabbit wrapper #592

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Conversation

gramhagen
Copy link
Collaborator

Description

new wrapper for vowpal wabbit to support common interface for model instantiation, fit, and predict methods. this is a stop-gap solution until the vw python bindings (and sklearn interface) can be cleanly installed in a conda env for use in the notebooks here.
the unittests do not require vw to be installed, but for this class to work for real vw must be installed on the operating system it is running on, and on the path for the python process calling this (i.e. commands such as 'vw -f test.model -d train.dat' should work)

Related Issues

#513
#534

Checklist:

  • My code follows the code style of this project, as detailed in our contribution guidelines.
  • I have added tests.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very good

reco_utils/recommender/vowpal_wabbit/__init__.py Outdated Show resolved Hide resolved
@miguelgfierro miguelgfierro merged commit 8216a88 into staging Mar 1, 2019
@miguelgfierro miguelgfierro deleted the gramhagen/vw_wrapper_clean branch March 1, 2019 15:33
yueguoguo pushed a commit that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants