Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged two concats into one #2075

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Merged two concats into one #2075

merged 2 commits into from
Mar 21, 2024

Conversation

daviddavo
Copy link
Collaborator

Description

Just replaced with a oneliner to make just one concat instead of two

Related Issues

References

[...] If function is None, the identity function is assumed, that is, all elements of iterable that are false are removed.
-- https://docs.python.org/3.9/library/functions.html#filter

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions. (not needed)
  • I have updated the documentation accordingly. (not needed)
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

Signed-off-by: David Davó <david@ddavo.me>
Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the code clearer and simpler.
I have an alternative suggestion, please check.

recommenders/models/rlrmc/RLRMCdataset.py Outdated Show resolved Hide resolved
Signed-off-by: David Davó <david@ddavo.me>
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @daviddavo! Super nice!

@miguelgfierro miguelgfierro merged commit 96fe3cf into staging Mar 21, 2024
38 checks passed
@miguelgfierro miguelgfierro deleted the daviddavo/less-concats branch March 21, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants