Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in Deeprec tests and adding more tests #1957

Merged
merged 11 commits into from
Jul 17, 2023
Merged

Bug in Deeprec tests and adding more tests #1957

merged 11 commits into from
Jul 17, 2023

Conversation

miguelgfierro
Copy link
Collaborator

Description

Adds more asserts and fix #1953

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@wutaomsft wutaomsft merged commit 60e06dc into staging Jul 17, 2023
@miguelgfierro miguelgfierro deleted the bug/deeprec_file branch July 22, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wutaomsft wutaomsft wutaomsft approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@simonzhaoms simonzhaoms Awaiting requested review from simonzhaoms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelgfierro @wutaomsft