Wutao/setup #1920
Merged
Wutao/setup #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutaomsft
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike and
simonzhaoms
as code owners
miguelgfierro
approved these changes
Apr 17, 2023
Comment on lines
+95
to
+96
| ## Setup for Experimental | ||
| <!-- FIXME FIXME 23/04/01 move to experimental. Have not tested --> |
There was a problem hiding this comment.
I think this is much better to what we had before. One thing that might be interesting to do is one section for developers, just to install for example:
pip install .[gpu,examples]
or if they want the latest development in staging:
git checkout staging
pip install .[gpu,example]
what do you think?
There was a problem hiding this comment.
Like the idea! could you add it? You may have the best idea what to include.
There was a problem hiding this comment.
makes sense, I'll do a new PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Substantially streamlined setup and also updated README
Checklist:
staging branchand not tomain branch.