Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multinomial_vae.py #1916

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Conversation

kone807
Copy link
Contributor

@kone807 kone807 commented Apr 9, 2023

corrected import for Adam optimizer

Description

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

miguelgfierro and others added 2 commits March 31, 2023 08:20
Staging to main: improvements in testing pipeline and documentation
corrected import for Adam optimizer
@miguelgfierro
Copy link
Collaborator

hi @kone807, does this fix #1915?

@kone807
Copy link
Contributor Author

kone807 commented Apr 11, 2023

hey @miguelgfierro, this and changing line 294 by adding legacy before adam in recommenders/models/vae/standard_vae.py fixes the errors and the code executes correctly with proper results.

@miguelgfierro
Copy link
Collaborator

do you want to push the change in the file standard_vae.py as well?

@kone807
Copy link
Contributor Author

kone807 commented Apr 11, 2023

@microsoft-github-policy-service agree

@miguelgfierro committed the changes. The current version works fine at my end, for both standard vae and multi vae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants