Optimized Python splitters #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuyangKe
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike and
wutaomsft
as code owners
A small notice. An alternative way to tell the team that you don't want us to merge is by creating a draft PR instead of a normal PR. Simon does it from time to time. There is no need to change this PR, this is just FYI in case you were not familiar :-) |
miguelgfierro
approved these changes
Jul 28, 2022
Co-authored-by: Miguel González-Fierro <3491412+miguelgfierro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrote Python splitter functions to improve efficiency.
Tested on synthetic datasets with 10 million records and 100,000 users. The runtime is reduced from 209.7s to 18.8s, indicating a 11x performance improvement.
Related Issues
Checklist:
staging branchand not tomain branch.