Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat SAR+ SQL queries #1772

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Reformat SAR+ SQL queries #1772

merged 3 commits into from
Jul 6, 2022

Conversation

simonzhaoms
Copy link
Collaborator

Description

This PR reformatted the SQL queries in SAR+ code including:

  1. Quote SQL names to allow spaces in column names
  2. Uppercase SQL keywords and functions
  3. Lowercase SQL alias and table names
  4. Wrap long lines

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@simonzhaoms
Reformat SQL queries and wrap long lines
65ad14d 
1. Quote SQL names to allow spaces in names
2. Uppercase SQL keywords and functions
3. Lowercase SQL alias and table names
4. Wrap long lines
@simonzhaoms
Check if the column timestamp exists
5f816ec
@simonzhaoms
Debug
3bff744
@simonzhaoms simonzhaoms marked this pull request as ready for review July 6, 2022 07:04
miguelgfierro
miguelgfierro approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonzhaoms simonzhaoms merged commit c8522b4 into staging Jul 6, 2022
@simonzhaoms simonzhaoms deleted the simonz/202207061321/sarplus-reformat-sql branch July 6, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonzhaoms @miguelgfierro