Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a fast failure in SAR+ if the similarity metric is not within the options #1743

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Add a fast failure in SAR+ if the similarity metric is not within the options #1743

merged 3 commits into from
Jun 16, 2022

Conversation

miguelgfierro
Copy link
Collaborator

Description

We want to fail in the constructure instead in the fit method if we add a similarity like "coocurranceeaefsadf"

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro miguelgfierro merged commit 4a29e8e into staging Jun 16, 2022
@miguelgfierro miguelgfierro deleted the miguelgfierro-patch-1 branch June 16, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonzhaoms simonzhaoms simonzhaoms approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelgfierro @simonzhaoms