Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKN improve #1722

Merged
merged 4 commits into from
Jun 2, 2022
Merged

DKN improve #1722

merged 4 commits into from
Jun 2, 2022

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #1722 (f42c71a) into staging (5d8ca7d) will increase coverage by 23.20%.
The diff coverage is n/a.

❗ Current head f42c71a differs from pull request most recent head 5cbeeff. Consider uploading reports for the commit 5cbeeff to get more accurate results

@@             Coverage Diff              @@
##           staging    #1722       +/-   ##
============================================
+ Coverage     0.00%   23.20%   +23.20%     
============================================
  Files           88       88               
  Lines         9142     9142               
============================================
+ Hits             0     2121     +2121     
- Misses           0     7021     +7021     
Flag Coverage Δ
nightly ?
pr-gate 23.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/mind.py 0.00% <0.00%> (ø)
recommenders/datasets/criteo.py 56.60% <0.00%> (+56.60%) ⬆️
recommenders/utils/spark_utils.py 84.61% <0.00%> (+84.61%) ⬆️
recommenders/datasets/movielens.py 66.37% <0.00%> (+66.37%) ⬆️
recommenders/datasets/download_utils.py 90.00% <0.00%> (+90.00%) ⬆️
recommenders/models/newsrec/io/mind_iterator.py 0.00% <0.00%> (ø)
recommenders/models/newsrec/models/base_model.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8ca7d...5cbeeff. Read the comment docs.

@miguelgfierro miguelgfierro merged commit ddabf28 into staging Jun 2, 2022
@miguelgfierro miguelgfierro deleted the miguelgfierro-patch-1 branch June 2, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants