Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review BPR #1704

Merged
merged 4 commits into from
May 12, 2022
Merged

Review BPR #1704

merged 4 commits into from
May 12, 2022

Conversation

miguelgfierro
Copy link
Collaborator

Description

Better explanation of BPR, in particular the pairwise ranking

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@miguelgfierro miguelgfierro changed the base branch from main to staging April 20, 2022 12:51
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #1704 (0be0b3e) into staging (4106333) will increase coverage by 23.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           staging    #1704       +/-   ##
============================================
+ Coverage     0.00%   23.32%   +23.32%     
============================================
  Files           87       87               
  Lines         9132     9132               
============================================
+ Hits             0     2130     +2130     
- Misses           0     7002     +7002     
Flag Coverage Δ
nightly ?
pr-gate 23.32% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/mind.py 0.00% <0.00%> (ø)
recommenders/datasets/movielens.py 66.37% <0.00%> (+66.37%) ⬆️
recommenders/datasets/download_utils.py 90.00% <0.00%> (+90.00%) ⬆️
recommenders/models/newsrec/io/mind_iterator.py 0.00% <0.00%> (ø)
recommenders/models/newsrec/models/base_model.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4106333...0be0b3e. Read the comment docs.

@miguelgfierro
Copy link
Collaborator Author

FYI @fazamani

Copy link
Collaborator

@anargyri anargyri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@miguelgfierro
Copy link
Collaborator Author

@anargyri could you please review this again?

@miguelgfierro miguelgfierro merged commit c9813d0 into staging May 12, 2022
@miguelgfierro miguelgfierro deleted the miguel/bpr branch May 12, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants