Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCF review #1703

Merged
merged 7 commits into from
May 3, 2022
Merged

NCF review #1703

merged 7 commits into from
May 3, 2022

Conversation

miguelgfierro
Copy link
Collaborator

Description

  • Added a link to the NCF deep dive notebook in readme
  • Moved NCF from hybrid to CF folder

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

Codecov Report

Merging #1703 (7c65465) into staging (4106333) will increase coverage by 23.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           staging    #1703       +/-   ##
============================================
+ Coverage     0.00%   23.32%   +23.32%     
============================================
  Files           87       87               
  Lines         9132     9132               
============================================
+ Hits             0     2130     +2130     
- Misses           0     7002     +7002     
Flag Coverage Δ
nightly ?
pr-gate 23.32% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/mind.py 0.00% <0.00%> (ø)
recommenders/datasets/movielens.py 66.37% <0.00%> (+66.37%) ⬆️
recommenders/datasets/download_utils.py 90.00% <0.00%> (+90.00%) ⬆️
recommenders/models/newsrec/io/mind_iterator.py 0.00% <0.00%> (ø)
recommenders/models/newsrec/models/base_model.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4106333...7c65465. Read the comment docs.

@miguelgfierro miguelgfierro merged commit c7307aa into staging May 3, 2022
@miguelgfierro miguelgfierro deleted the miguel/ncf branch May 3, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants