Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github workflow for SAR+ packaging #1680

Merged
merged 7 commits into from
Mar 24, 2022
Merged

Conversation

simonzhaoms
Copy link
Collaborator

Description

  1. Add steps to generate Python wheel files
  2. Update README for missing JAR link
  3. Add tests for ADB 10.4 LTS

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #1680 (05ae411) into staging (ceb47e9) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 05ae411 differs from pull request most recent head 7854340. Consider uploading reports for the commit 7854340 to get more accurate results

@@             Coverage Diff             @@
##           staging    #1680      +/-   ##
===========================================
- Coverage    23.20%   23.12%   -0.09%     
===========================================
  Files           88       87       -1     
  Lines         9101     9091      -10     
===========================================
- Hits          2112     2102      -10     
  Misses        6989     6989              
Flag Coverage Δ
pr-gate 23.12% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/movielens.py 66.37% <100.00%> (ø)
recommenders/datasets/spark_splitters.py 87.27% <100.00%> (ø)
recommenders/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fbdd06...7854340. Read the comment docs.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contrib/sarplus/README.md Outdated Show resolved Hide resolved
@simonzhaoms simonzhaoms merged commit 93c9df2 into staging Mar 24, 2022
@miguelgfierro miguelgfierro deleted the simonz/sarplus-package branch March 24, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants