Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Spark env variables in tox for nightly test #1659

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Set Spark env variables in tox for nightly test #1659

merged 3 commits into from
Mar 3, 2022

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Mar 3, 2022 •
edited
Loading

Description

The PYSPARK env variables are not set properly in the nightly GitHub tests. This leads to some test failures.
#1655 did not fix this, instead the environment variables should be set inside tox.ini.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro miguelgfierro merged commit 1a22b74 into staging Mar 3, 2022
@miguelgfierro miguelgfierro deleted the andreas/tox2 branch March 3, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anargyri @miguelgfierro