Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding codespace deployment #1521

Merged
merged 18 commits into from
Oct 8, 2021
Merged

Adding codespace deployment #1521

merged 18 commits into from
Oct 8, 2021

Conversation

gramhagen
Copy link
Collaborator

Description

Adding ability to deploy repo to github codespaces

Related Issues

#1502

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • [N/A] I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
Copy link
Collaborator

@gramhagen for the error you are getting in dsvm_notebook_linux_pyspark, see this comment: #1500 (comment)

@gramhagen gramhagen changed the title Scgraham/codespace docker Adding codespace deployment Sep 10, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1521 (5aae312) into staging (9f19411) will increase coverage by 0.07%.
The diff coverage is 94.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1521      +/-   ##
===========================================
+ Coverage    62.12%   62.20%   +0.07%     
===========================================
  Files           84       84              
  Lines         8397     8442      +45     
===========================================
+ Hits          5217     5251      +34     
- Misses        3180     3191      +11     
Impacted Files Coverage Δ
recommenders/evaluation/spark_evaluation.py 86.66% <ø> (ø)
recommenders/evaluation/python_evaluation.py 93.68% <94.11%> (-3.21%) ⬇️
recommenders/utils/spark_utils.py 96.15% <100.00%> (+0.15%) ⬆️
recommenders/datasets/movielens.py 76.96% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 448982d...5aae312. Read the comment docs.

@gramhagen gramhagen merged commit 846d214 into staging Oct 8, 2021
@miguelgfierro miguelgfierro deleted the scgraham/codespace-docker branch December 13, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants