Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing import in multinomial_vae.py and standard_vae.py #1508

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

miguelgfierro
Copy link
Collaborator

Description

VAE algos failing due to missing import

Related Issues

#1504

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@codecov-commenter
Copy link

Codecov Report

Merging #1508 (987957e) into staging (3e23511) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1508      +/-   ##
===========================================
- Coverage    61.96%   61.95%   -0.01%     
===========================================
  Files           84       84              
  Lines         8368     8369       +1     
===========================================
  Hits          5185     5185              
- Misses        3183     3184       +1     
Impacted Files Coverage Δ
recommenders/models/vae/multinomial_vae.py 0.00% <ø> (ø)
recommenders/models/vae/standard_vae.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e23511...987957e. Read the comment docs.

@miguelgfierro
Copy link
Collaborator Author

merging this since it was approved by the original requester: #1504 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants