Zhangya/metrics formula #1488
Merged
Zhangya/metrics formula #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanZhangADS
requested review from
anargyri,
gramhagen,
loomlike,
miguelgfierro,
wutaomsft and
yueguoguo
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
4 tasks
Comment on lines
168
to
173
| "from recommenders.utils.timer import Timer\n", | ||
| "from recommenders.datasets import movielens\n", | ||
| "from recommenders.utils.notebook_utils import is_jupyter\n", | ||
| "from recommenders.datasets.spark_splitters import spark_random_split\n", | ||
| "from recommenders.evaluation.spark_evaluation import SparkRatingEvaluation, SparkRankingEvaluation, SparkDiversityEvaluation\n", | ||
| "from recommenders.utils.spark_utils import start_or_get_spark\n", |
There was a problem hiding this comment.
hey Yan, can you please revert this change. We renamed reco_utils to recommenders, see this PR: #1485 this is why the test it is failing.
Also, you need to reinstall recommenders in your local machine: pip install -e .[all]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The formula cannot be properly displayed
Related Issues
Checklist:
staging branchand not tomain branch.