Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions for installation in a virtual environment #1476

Merged
merged 9 commits into from
Jul 16, 2021
Merged

Instructions for installation in a virtual environment #1476

merged 9 commits into from
Jul 16, 2021

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Jul 14, 2021 •
edited by miguelgfierro
Loading

Description

  • Added instructions in SETUP.md about how to pip install the package inside a venv running in a docker container
  • Added venv as an option in other text.

Related Issues

#1468

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@anargyri anargyri changed the base branch from main to staging July 14, 2021 15:42
miguelgfierro
miguelgfierro approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anargyri anargyri enabled auto-merge July 15, 2021 14:55
@miguelgfierro miguelgfierro merged commit 27790b7 into staging Jul 16, 2021
@miguelgfierro miguelgfierro deleted the andreas/venv branch July 16, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anargyri @miguelgfierro