Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange README and SETUP files; add info about pip install #1431

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Jun 7, 2021

Description

  • Separated the part about conda and yaml files from the setup requirements into a new Markdown file.
  • Replaced references to conda envs with more general envs.
  • Added references to pip installation in the setup guide.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
Copy link
Collaborator

We have right now 3 places with dependencies, the old conda file, the setup.py and docs/requirements.txt. And also, two ways of installing, with pip and with conda.

Maybe we can consider the advantages/disadvantages of having this versus having 1 single place where we have all deps and only installation with pip. Do you guys think this is possible?

@gramhagen
Copy link
Collaborator

yeah, i agree it will be best if we can consolidate around using pip install for dependencies and remove the conda setup, should we capture this in a new issue?

@anargyri
Copy link
Collaborator Author

anargyri commented Jun 8, 2021

yeah, i agree it will be best if we can consolidate around using pip install for dependencies and remove the conda setup, should we capture this in a new issue?

Yes, feel free to create an issue around this. Let's leave it though for after publication on PyPI.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging this, we'll review in the future if needed

@miguelgfierro miguelgfierro merged commit a566e9f into pipeline_release Jun 14, 2021
@miguelgfierro miguelgfierro deleted the andreas/setup branch June 14, 2021 15:03
@miguelgfierro miguelgfierro mentioned this pull request Jun 14, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants