Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline for release and updated tests #1427

Merged
merged 169 commits into from
Jun 11, 2021
Merged

Pipeline for release and updated tests #1427

merged 169 commits into from
Jun 11, 2021

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Jun 4, 2021

Description

Details #1408

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
Copy link
Collaborator Author

yeah, that is defined in the build pipeline, it looks like clean is not set to true (at least for this pipeline). You will need to edit the pipeline -> triggers -> yaml -> get sources -> clean -> set to true
https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/pipeline-options-for-git?view=azure-devops&tabs=yaml

do you know if this is something that we can add in the yaml file directly?

@gramhagen
Copy link
Collaborator

yeah, that is defined in the build pipeline, it looks like clean is not set to true (at least for this pipeline). You will need to edit the pipeline -> triggers -> yaml -> get sources -> clean -> set to true
https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/pipeline-options-for-git?view=azure-devops&tabs=yaml

do you know if this is something that we can add in the yaml file directly?

yes, in the documentation listed you can either add a checkout step, or use the workspace setting for any job

Copy link
Collaborator

@anargyri anargyri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @miguelgfierro, you are now officially the master of build pipelines!

Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of my comments are questions so I can better understand how things work, maybe we should set up some time to talk this through, i don't think any of them should block this.

it would be nice though to add a readme that explains how the release process works, it looks like we need to tag a release starting with 0. or 1. and then some artifacts are pushed to github, then we manually upload them to pypi?

pyproject.toml Show resolved Hide resolved
dev-requirements.txt Show resolved Hide resolved
@miguelgfierro miguelgfierro merged commit 6dcb860 into staging Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants