Zhangya

[YanZhangADS]

Description

match recommenders/docs/source/*.rst files with code

Related Issues

Checklist:

• I have followed the contribution guidelines and code style for this project.
• I have added tests covering my contributions.
• I have updated the documentation accordingly.
• This PR is being made to staging branch and not to main branch.

[miguelgfierro]

great progress @YanZhangADS!

[gramhagen]

@YanZhangADS just a small nitpick, sometimes the branch names get confusing so it's better if you can put more descriptive naming in the branch
e.g. zhangya -> zhangya/doc_fix or something like that

[miguelgfierro]

@YanZhangADS I think another thing it would be good to update is the readme https://github.com/microsoft/recommenders/tree/main/docs

if you have already reviewed the html files, let me know, and I'll do another pass

[YanZhangADS]

@YanZhangADS I think another thing it would be good to update is the readme https://github.com/microsoft/recommenders/tree/main/docs

if you have already reviewed the html files, let me know, and I'll do another pass

Should I check-in all the html files in "build" folder to my branch?

How would you suggest to update the doc? It looks good to me.

[miguelgfierro]

I have done one pass to review the code and there are components missing. Here a PR with some of the fixes: #1425

Inside the folder recommenders.deeprec.models we need to add the modules of graphrec and sequentials. Also, since DeepRec is a lib inside our lib, it would be cool to have a second level in the doc, so in the index of modules, when you press DeepRec, there is a menu with all the algos.

@zhangya let me know when you want me to take a look again

[miguelgfierro]

this is really good @YanZhangADS, congrats! really good job