Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NNI Test Case #1131

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Fix NNI Test Case #1131

merged 1 commit into from
Jun 30, 2020

Conversation

seanytak
Copy link
Contributor

Description

Fixed the NNI test case.
The NNI server returns a json object with a number of escaped characters such as

"finalMetricData":[{"timestamp":1593483585712,"trialJobId":"yr1Mf","parameterId":"0","type":"FINAL","sequence":0,"data":"\"{\\\"rmse\\\": 3.2157589095060417, \\\"default\\\": 0.10604453870625664, \\\"ndcg_at_k\\\": 0.12934821010667147}\""}]

The data in mock_trials for the test case test_get_trials under tests/unit/test_nni_utils.py is now formatted to match NNI.

Related Issues

Fixes #1125

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

miguelgfierro
miguelgfierro approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks

@miguelgfierro miguelgfierro merged commit 6d10de9 into recommenders-team:staging Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanytak @miguelgfierro