Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o16n ignite (azureml and cosmosdb) update merge #1003

Merged
merged 25 commits into from
Dec 9, 2019

Conversation

loomlike
Copy link
Collaborator

@loomlike loomlike commented Dec 7, 2019

Description

Fix and merge Ignite branch (ALS o16n notebook) which includes following changes:

  • Ignite branch work: AzureML and cosmosDB scripts updated by @Chris113113 @gramhagen
  • Top-K result writing to CosmosDB performance fix w/ coalesce(1)

Related Issues

#972
#962

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@loomlike loomlike mentioned this pull request Dec 7, 2019
3 tasks
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great Jun, there is one minor thing, I can't see the image of the architecture when I look at the notebook on github https://github.com/microsoft/recommenders/blob/38f887e3cb62f474d6f0a2e13cf737e99f5017ec/notebooks/05_operationalize/als_movie_o16n.ipynb

Can you please check?

@loomlike
Copy link
Collaborator Author

loomlike commented Dec 9, 2019

@miguelgfierro githubusercontent link somehow didn't work. I changed it back to what we have (blob storage image). Thanks!

@miguelgfierro miguelgfierro merged commit 58e09e8 into staging Dec 9, 2019
@miguelgfierro miguelgfierro deleted the jumin/o16n_merge branch December 9, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants