Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple blobs #29

Closed
wants to merge 56 commits into from
Closed

Decouple blobs #29

wants to merge 56 commits into from

Commits on Feb 19, 2023

  1. Decouple blobs using data_availability_handle

    @emhane
    emhane committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    472d153 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. fixup! Decouple blobs using data_availability_handle

    @emhane
    emhane committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    49b25d5 View commit details
    Browse the repository at this point in the history

  2. Enable parallelisation of kzg and payload verification

    @emhane
    emhane committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    4ab8006 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Cache executed blocks pedning availability

    @emhane
    emhane committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    94bb6ff View commit details
    Browse the repository at this point in the history

  2. Return block when availability fails

    @emhane
    emhane committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    078a747 View commit details
    Browse the repository at this point in the history

  3. LRU cache blob-block channel handles

    @emhane
    emhane committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    1e108da View commit details
    Browse the repository at this point in the history

  4. Clean up

    @emhane
    emhane committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    cc152b0 View commit details
    Browse the repository at this point in the history

  5. More clean up

    @emhane
    emhane committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    88109cc View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @emhane
    emhane committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    4392728 View commit details
    Browse the repository at this point in the history

  7. Implement AsBlock

    @emhane
    emhane committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    f61e058 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. fixup! Implement AsBlock

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    e6c1e98 View commit details
    Browse the repository at this point in the history

  2. Use mpsc from futures crate

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    50706a4 View commit details
    Browse the repository at this point in the history

  3. fixup! Use mpsc from futures crate

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    972e89f View commit details
    Browse the repository at this point in the history

  4. fixup! Use mpsc from futures crate

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    0873865 View commit details
    Browse the repository at this point in the history

  5. Implement a spec criteria for blob gossip validation

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    5a840fd View commit details
    Browse the repository at this point in the history

  6. Set default parameter based on checks in last commit

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2998b7f View commit details
    Browse the repository at this point in the history

  7. Clean up blob errors

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    9fdbbd5 View commit details
    Browse the repository at this point in the history

  8. fixup! Clean up blob errors

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    1740902 View commit details
    Browse the repository at this point in the history

  9. Misc fixes

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    228145d View commit details
    Browse the repository at this point in the history

  10. Rename and clean up AsBlock trait

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    032758d View commit details
    Browse the repository at this point in the history

  11. fixup! Rename and clean up AsBlock trait

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2aac365 View commit details
    Browse the repository at this point in the history

  12. fixup! Rename and clean up AsBlock trait

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    5aa4a4c View commit details
    Browse the repository at this point in the history

  13. Clean up use of trait IntoAvailabilityPendingBlock

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2df4298 View commit details
    Browse the repository at this point in the history

  14. fixup! Clean up use of trait IntoAvailabilityPendingBlock

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ef163fe View commit details
    Browse the repository at this point in the history

  15. Give new purpose to BlockWrapper

    @emhane
    emhane committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    8b859dd View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Use IntoWrappedAvailabilityPendingBlock to keep gossip metadata for s… 

    …lasher
    @emhane
    emhane committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    470da42 View commit details
    Browse the repository at this point in the history

  2. fixup! Use IntoWrappedAvailabilityPendingBlock to keep gossip metadat… 

    …a for slasher
    @emhane
    emhane committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    52ee0b3 View commit details
    Browse the repository at this point in the history

  3. fixup! Use IntoWrappedAvailabilityPendingBlock to keep gossip metadat… 

    …a for slasher
    @emhane
    emhane committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    bb9a617 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. fixup! Use IntoWrappedAvailabilityPendingBlock to keep gossip metadat… 

    …a for slasher
    @emhane
    emhane committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    6d48cc9 View commit details
    Browse the repository at this point in the history

  2. Make use of pending blobs and pending blocks thread safe

    @emhane
    emhane committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    45c869f View commit details
    Browse the repository at this point in the history

  3. fixup! Make use of pending blobs and pending blocks thread safe

    @emhane
    emhane committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    ba29236 View commit details
    Browse the repository at this point in the history

  4. fixup! Make use of pending blobs and pending blocks thread safe

    @emhane
    emhane committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    97a1847 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Make new availability traits more idiomatic

    @emhane
    emhane committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    5b61fc8 View commit details
    Browse the repository at this point in the history

  2. fixup! Make new availability traits more idiomatic

    @emhane
    emhane committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    af62917 View commit details
    Browse the repository at this point in the history

  3. fixup! Make new availability traits more idiomatic

    @emhane
    emhane committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    6396075 View commit details
    Browse the repository at this point in the history

  4. fixup! Make new availability traits more idiomatic

    @emhane
    emhane committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    5c7b484 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Fix up stream polling

    @emhane
    emhane committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    afe52af View commit details
    Browse the repository at this point in the history

  2. Fixup data availability handle polling

    @emhane
    emhane committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    eabc04f View commit details
    Browse the repository at this point in the history

  3. Clean up AsSignedBlock trait

    @emhane
    emhane committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    7b1d41d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Boil down TryIntoAvailableBlock and IntoAvailabilityPendingBlock to o… 

    …ne trait
    @emhane
    emhane committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    cdaf2be View commit details
    Browse the repository at this point in the history

  2. fixup! Boil down TryIntoAvailableBlock and IntoAvailabilityPendingBlo… 

    …ck to one trait
    @emhane
    emhane committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    a549d35 View commit details
    Browse the repository at this point in the history

  3. Clean up IntoWrappedAvailabilityPendingBlock

    @emhane
    emhane committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    b6b9b97 View commit details
    Browse the repository at this point in the history

  4. fixup! Boil down TryIntoAvailableBlock and IntoAvailabilityPendingBlo… 

    …ck to one trait
    @emhane
    emhane committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    93db7ed View commit details
    Browse the repository at this point in the history

  5. fixup! Boil down TryIntoAvailableBlock and IntoAvailabilityPendingBlo… 

    …ck to one trait
    @emhane
    emhane committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    ec6bec2 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Allow compilation with no slasher backend (sigp#3888) 

    ## Proposed Changes

Allowing compiling without MDBX by running:

```bash
CARGO_INSTALL_EXTRA_FLAGS="--no-default-features" make
```

The reasons to do this are several:

- Save compilation time if the slasher won't be used
- Work around compilation errors in slasher backend dependencies (our pinned version of MDBX is currently not compiling on FreeBSD with certain compiler versions).

## Additional Info

When I opened this PR we were using resolver v1 which [doesn't disable default features in dependencies](https://doc.rust-lang.org/cargo/reference/features.html#resolver-version-2-command-line-flags), and `mdbx` is default for the `slasher` crate. Even after the resolver got changed to v2 in sigp#3697 compiling with `--no-default-features` _still_ wasn't turning off the slasher crate's default features, so I added `default-features = false` in all the places we depend on it.

Co-authored-by: Michael Sproul <micsproul@gmail.com>
    @michaelsproul @emhane
    2 people authored and emhane committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    f4cc9c6 View commit details
    Browse the repository at this point in the history

  2. Executed availability pending block cache

    @emhane
    emhane committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    3be7225 View commit details
    Browse the repository at this point in the history

  3. Use availability enum wrapper in reprocess queue

    @emhane
    emhane committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    aea7a60 View commit details
    Browse the repository at this point in the history

  4. Set downloaded blocks to one type

    @emhane
    emhane committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    99a8bac View commit details
    Browse the repository at this point in the history

  5. Fix import

    @emhane
    emhane committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    84a191b View commit details
    Browse the repository at this point in the history

  6. Patch hole in error handling

    @emhane
    emhane committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    89623f2 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Generalize as X trait for use for blob containers

    @emhane
    emhane committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    4e9f87e View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Make full use of mpsc

    @emhane
    emhane committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    b320999 View commit details
    Browse the repository at this point in the history

  2. fixup! Make full use of mpsc

    @emhane
    emhane committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    aee8d16 View commit details
    Browse the repository at this point in the history

  3. fixup! Generalize as X trait for use for blob containers

    @emhane
    emhane committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    b382238 View commit details
    Browse the repository at this point in the history

  4. fixup! Generalize as X trait for use for blob containers

    @emhane
    emhane committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    0502135 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Continue plugging in my decoupling code into block processing

    @emhane
    emhane committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    2d281cb View commit details
    Browse the repository at this point in the history