Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider delaying (buffering) outgoing responses until request is complete in #273

Closed
clue opened this issue Dec 8, 2017 · 1 comment
Closed

Comments

@clue
Copy link
Member

clue commented Dec 8, 2017

Some Browsers consider a request failed when a response is sent before the entire request has gone out. We may want to look into delaying (buffering) outgoing responses until the complete request has been received.

Once #259 is in, this is less of an issue, because we default to buffering the whole incoming request first before invoking the request handler. However, this can still easily be reproduced by using the StreamingServer (see example 1).

This ticket exists for the reference, to document this behavior and as an RFC for future changes.

@clue
Copy link
Member Author

clue commented Mar 20, 2018

Now that #259 is in, this is no longer an issue for me personally.

I'm closing this for now as it hasn't received any input in a while and I have no plans to change this myself anytime soon. Please come back if you feel this is still an issue and we can reopen this 👍

@clue clue closed this as completed Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant