Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event["target"] value for radio input and checkboxes is always 'on' #1188

Open
Archmonger opened this issue Jan 14, 2024 · 1 comment · May be fixed by #1126
Open

event["target"] value for radio input and checkboxes is always 'on' #1188

Archmonger opened this issue Jan 14, 2024 · 1 comment · May be fixed by #1126
Labels
priority-1-high Should be resolved ASAP. type-bug About something that isn't working

Comments

@Archmonger
Copy link
Contributor

Current Situation

The value for any serialized checkbox or radio button is always on when viewed within an event["target"]. This effectively makes them unusable within a form's on_submit event.

Proposed Actions

Fix how we serialize these input fields, and look for any other outliers that might exist.
@Archmonger Archmonger added type-bug About something that isn't working priority-1-high Should be resolved ASAP. labels Jan 14, 2024
This was referenced Jan 14, 2024
Open
Draft
@zx013
Copy link

zx013 commented Feb 7, 2024

If set value xxx in radio input, the value always be xxx. So I can not get which radio input I choose.

@Archmonger Archmonger mentioned this issue Feb 14, 2024
Open
@Archmonger Archmonger mentioned this issue Feb 21, 2024
Open
@Archmonger Archmonger linked a pull request Apr 25, 2024 that will close this issue
Added checked: element.checked to INPUT in elementConverters #1126
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-1-high Should be resolved ASAP. type-bug About something that isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added checked: element.checked to INPUT in elementConverters DennisHC/reactpy
2 participants
@zx013 @Archmonger