Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListItem legend may be a node as well #1496

Merged
merged 1 commit into from
Jul 13, 2017
Merged

ListItem legend may be a node as well #1496

merged 1 commit into from
Jul 13, 2017

Conversation

olegstepura
Copy link
Contributor

Currently it works, but produces a warning by react typechecking

@olegstepura
ListItem legend may be a node as well
40857c4 
Currently it works, but produces a warning by react typechecking
@olegstepura
Copy link
Contributor Author

olegstepura commented May 29, 2017 •
edited
Loading

@javivelasco please review this, I have this pain of seeng lots of warnings from React typechiecking but everything else works. Thanks!

@olegstepura
Copy link
Contributor Author

Anything stops from merging this?

@javivelasco
Copy link
Member

Thanks!

@javivelasco javivelasco merged commit a6eb5c5 into react-toolbox:dev Jul 13, 2017
@javivelasco
Copy link
Member

Sorry, personal issues are pushing me away from dedicating time to the project. That's the reason for this stupid inactivity

javivelasco added a commit that referenced this pull request Jul 13, 2017
@javivelasco
Merge branch 'dev' of github.com:soyjavi/react-toolbox into dev
8304c1e 
* 'dev' of github.com:soyjavi/react-toolbox:
  ListItem legend may be a node as well (#1496)
  Allow pass inverse to IconMenu (#1490)
  Fix media queries panel height calculations (#1467)
  Allow to change FontIcon for Tab by passing it into the factory (#1439)
  Added required?: boolean; (#1491)
@olegstepura
Copy link
Contributor Author

Hopefully you will solve personal issues to allow yourself do what you love =)

@olegstepura olegstepura mentioned this pull request Aug 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olegstepura @javivelasco